search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
194 stars 82 forks source link

fix flaky integration test DemoActorReminderOnceImpl #553

Closed MregXN closed 9 months ago

MregXN commented 9 months ago

Description

it fails due to the following log

 test/actor/DemoActorReminderOnceImpl.ts:24:7 - error TS2345: Argument of type 'undefined' is not assignable to parameter of type 'Duration'.

the period should be able to be undefined.

Issue reference

Please refer to the the point 4 of issue #7128 in dapr/dapr.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (66d4bd0) 100.00% compared to head (010f26d) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #553 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 6 6 Branches 1 1 ========================================= Hits 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shubham1172 commented 9 months ago

Thank you so much for looking into this @MregXN, these improvements will go a long way in increasing the SDK e2e test stability.

MregXN commented 9 months ago

ready to review