search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
192 stars 80 forks source link

Workflow authoring support #563

Closed kaibocai closed 6 months ago

kaibocai commented 7 months ago

Description

This PR initiates the support for dapr workflow.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: https://github.com/dapr/js-sdk/issues/463 and https://github.com/dapr/js-sdk/issues/545

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  1. durabletask-js haven't been released under Microsoft namespace, I am working on it and keep tracking it.
  2. I still need to add test suits (unit, e2e) for this PR, @shubham1172, @DeepanshuA please let me know if you can help with it.
  3. I definitely need a review and suggestions from you @DeepanshuA and @shubham1172 on this PR as it's my first few JS PR, still learning it.

cc @cgillum, @rabollin, @torosent

codecov[bot] commented 6 months ago

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (998f8ee) 35.36% compared to head (6fb6544) 55.79%. Report is 2 commits behind head on main.

:exclamation: Current head 6fb6544 differs from pull request most recent head fb4ef7f. Consider uploading reports for the commit fb4ef7f to get more accurate results

Files Patch % Lines
src/workflow/runtime/WorkflowRuntime.ts 64.10% 13 Missing and 1 partial :warning:
src/workflow/client/DaprWorkflowClient.ts 67.56% 11 Missing and 1 partial :warning:
src/workflow/internal/index.ts 50.00% 9 Missing and 3 partials :warning:
src/workflow/runtime/WorkflowContext.ts 55.00% 9 Missing :warning:
src/workflow/client/WorkflowFailureDetails.ts 20.00% 4 Missing :warning:
src/workflow/client/WorkflowState.ts 76.47% 4 Missing :warning:
src/workflow/runtime/WorkflowActivityContext.ts 33.33% 4 Missing :warning:
src/workflow/runtime/WorkflowRuntimeStatus.ts 78.94% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #563 +/- ## =========================================== + Coverage 35.36% 55.79% +20.43% =========================================== Files 95 14 -81 Lines 10570 319 -10251 Branches 452 63 -389 =========================================== - Hits 3738 178 -3560 + Misses 6745 124 -6621 + Partials 87 17 -70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.