dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
192 stars 80 forks source link

Fix Configuration GRPC calls not sending metadata #571

Closed tlund101 closed 5 months ago

tlund101 commented 5 months ago

Description

When sending a request for Configurations from Azure App Config, the call would silently drop the metadata that was sent with it. This would cause keys to be returned only if they had no labels on them when specified.

Having some unrelated errors preventing my local tests from running, though I did validate the change with the app that created this issue. Let me know if I'm missing a spot that should also be updated, as I'm new to this codebase.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #570

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5c2b40a) 55.79% compared to head (2d0faf8) 55.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #571 +/- ## ======================================= Coverage 55.79% 55.79% ======================================= Files 14 14 Lines 319 319 Branches 63 63 ======================================= Hits 178 178 Misses 124 124 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.