search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
192 stars 80 forks source link

Regression: Sidecar not found by js-sdk in several cases using final release of 3.3.0 #580

Closed paulyuk closed 5 months ago

paulyuk commented 5 months ago

Repro as seen in quickstart steps and failing tests https://github.com/dapr/quickstarts/issues/998

simple repro:

dapr run --app-id order-processor --resources-path ../../../components/ --app-protocol grpc --dapr-grpc-port 3500 -- node index.js
ℹ️  Dapr sidecar is up and running.
ℹ️  Updating metadata for appPID: 65932
ℹ️  Updating metadata for app command: node index.js
✅  You're up and running! Both Dapr and your app logs will appear here.

== APP == 2024-03-06T18:22:57.243Z INFO [GRPCClient, GRPCClient] Opening connection to localhost:3500
== APP == 2024-03-06T18:22:57.248Z INFO [GRPCClient, GRPCClient] Awaiting Sidecar to be Started
== APP == Could not get config item, err:Error: DAPR_SIDECAR_COULD_NOT_BE_STARTED
paulyuk commented 5 months ago

@shubham1172 replied in another chat

It is due to this proto change https://github.com/dapr/dapr/commit/4d4c8b937b63fc5303a2a1dc90eb966c500350a5 Strangely the tests did not catch it (which is a repair item), but I will fix this in a few hours.

paulyuk commented 5 months ago

Verified!

✅  You're up and running! Both Dapr and your app logs will appear here.

== APP == 2024-03-06T21:15:20.250Z INFO [GRPCClient, GRPCClient] Opening connection to localhost:3500
== APP == Configuration for orderId1: {"key":"orderId1","value":"103","version":"","metadata":{}}
== APP == Configuration for orderId2: {"key":"orderId2","value":"104","version":"","metadata":{}}