search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
192 stars 80 forks source link

fix(proto): update gRPC requests to use the correct request parameters #581

Closed shubham1172 closed 5 months ago

shubham1172 commented 5 months ago

Description

Some protos were updated in https://github.com/dapr/dapr/commit/4d4c8b937b63fc5303a2a1dc90eb966c500350a5, which were not changed in the SDK. Two problems, (1) no compile time errors (2) our e2e tests were ... not reporting failure! 🤦🏻

This PR: (1) fixes the two specific requests that had changed in the proto - getMetadata and shutdown (2) fixes the NPM script which was using ; instead of && for e2e tests (https://unix.stackexchange.com/questions/187145/whats-the-difference-between-semicolon-and-double-ampersand) (3) removes a test introduced in https://github.com/dapr/js-sdk/pull/571, which won't work with Redis. It need Postgres/Azure app config.

Issue reference

Please reference the issue this PR will close: #580

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.79%. Comparing base (1f8c1f9) to head (f5390c2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #581 +/- ## ======================================= Coverage 55.79% 55.79% ======================================= Files 14 14 Lines 319 319 Branches 63 63 ======================================= Hits 178 178 Misses 124 124 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.