dapr / js-sdk

Dapr SDK for Javascript

Apache License 2.0

192 stars 80 forks source link

Updated the holopin.yaml to use the sdk badge #590

Closed AjaySDwivedi1 closed 3 months ago

AjaySDwivedi1 commented 3 months ago

Description

Please explain the changes you've made Added code from issue #589 to holopin.yml

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #589

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

shubham1172 commented 3 months ago

Hello @AjaySDwivedi1, welcome to this SDK 👋🏻 Can you please fix the DCO?

AjaySDwivedi1 commented 3 months ago

Hello @AjaySDwivedi1, welcome to this SDK 👋🏻 Can you please fix the DCO?

I added to the another commit. Let me know if that wrong and I'll do it again.

AjaySDwivedi1 commented 3 months ago

Hi @AjaySDwivedi1 existing content of the holopin.yaml file should be removed. Only the YAML that is mentioned in the issue should be present in the file. Thank you!

Hey, I made the necessary changes. Let me know if I need to do anything else!

AjaySDwivedi1 commented 3 months ago

@marcduiker Did do the DCO right? The merge for the PR is still blocked. If I need to fix something let me know.

marcduiker commented 3 months ago

@marcduiker Did do the DCO right? The merge for the PR is still blocked. If I need to fix something let me know.

@AjaySDwivedi1 The DCO/sign-off is missing from the initial commit.

I think this should do it:

git rebase --signoff HEAD~3 git push -f

AjaySDwivedi1 commented 3 months ago

@marcduiker Thank you! I was able to do the DOC right this time!

marcduiker commented 3 months ago

@holopin-bot @AjaySDwivedi1 Thank you for this contribution!

holopin-bot[bot] commented 3 months ago

Congratulations @AjaySDwivedi1, you just earned a badge! Here it is: https://holopin.io/claim/clvc3nihd91280fl8aal67evs

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!