search

dapr / js-sdk

Dapr SDK for Javascript
Apache License 2.0
192 stars 80 forks source link

Do not log options in HTTPServer to prevent circular reference #592

Closed shubham1172 closed 3 months ago

shubham1172 commented 3 months ago

Description

Having a debug log with options was causing a circular reference while using HTTP Server (see attached issue). This PR simply removes the logs and fixes it.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #488

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

marcduiker commented 3 months ago

@holopin-bot @shubham1172 :)

holopin-bot[bot] commented 3 months ago

Congratulations @shubham1172, you just earned a badge! Here it is: https://holopin.io/claim/clvwg8rgh02120fmem84boi2t

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!