search

dapr / php-sdk

Dapr SDK for PHP
Apache License 2.0
70 stars 15 forks source link

Add actor reentrancy support & reminder partitioning #112

Closed withinboredom closed 3 years ago

withinboredom commented 3 years ago

Description

This adds support for actor reentrency

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #89

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-commenter commented 3 years ago

Codecov Report

Merging #112 (7d0f90c) into main (ea43e72) will decrease coverage by 0.78%. The diff coverage is 65.51%.

:exclamation: Current head 7d0f90c differs from pull request most recent head 23c1468. Consider uploading reports for the commit 23c1468 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##               main     #112      +/-   ##
============================================
- Coverage     76.99%   76.20%   -0.79%     
- Complexity      551      560       +9     
============================================
  Files            66       68       +2     
  Lines          1769     1786      +17     
============================================
- Hits           1362     1361       -1     
- Misses          407      425      +18
Impacted Files Coverage Δ
src/lib/Middleware/Defaults/ActorToken.php 0.00% <0.00%> (ø)
src/lib/Client/DaprHttpClient.php 54.83% <50.00%> (-0.34%) :arrow_down:
src/lib/Actors/ActorConfig.php 66.66% <100.00%> (-25.34%) :arrow_down:
src/lib/Actors/ReentrantConfig.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea43e72...23c1468. Read the comment docs.