search

dapr / php-sdk

Dapr SDK for PHP
Apache License 2.0
72 stars 15 forks source link

Allow ^2.0 and ^3.0 of psr/log #127

Closed hendrikheil closed 2 years ago

hendrikheil commented 2 years ago

Description

This PR seeks to add support for API-compatible versions of psr/log

Issue reference

126

Checklist

hendrikheil commented 2 years ago

@withinboredom The psr/log update should now be good to go. I'll send another PR for the CloudEvents replacement

codecov-commenter commented 2 years ago

Codecov Report

Merging #127 (3d12c8e) into main (f0d66c3) will decrease coverage by 2.50%. The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #127      +/-   ##
============================================
- Coverage     75.99%   73.48%   -2.51%     
  Complexity      562      562              
============================================
  Files            69       72       +3     
  Lines          1791     1746      -45     
============================================
- Hits           1361     1283      -78     
- Misses          430      463      +33
Impacted Files Coverage Δ
src/lib/Client/HttpStateTrait.php 78.00% <0.00%> (-3.04%) :arrow_down:
src/lib/SecretManager.php 72.72% <0.00%> (-2.28%) :arrow_down:
src/lib/Actors/Reminder.php 84.00% <0.00%> (-1.19%) :arrow_down:
src/lib/Actors/ActorConfig.php 65.51% <0.00%> (-1.15%) :arrow_down:
src/lib/Actors/Generators/DynamicGenerator.php 88.63% <0.00%> (-0.95%) :arrow_down:
src/lib/Client/PromiseHandlingTrait.php 92.30% <0.00%> (-0.55%) :arrow_down:
src/lib/App.php 84.73% <0.00%> (-0.46%) :arrow_down:
src/lib/State/TransactionalState.php 91.66% <0.00%> (-0.40%) :arrow_down:
src/lib/PubSub/CloudEvent.php 80.35% <0.00%> (-0.35%) :arrow_down:
src/lib/Serialization/Serializer.php 94.73% <0.00%> (-0.27%) :arrow_down:
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0d66c3...3d12c8e. Read the comment docs.

withinboredom commented 2 years ago

I expect the integration tests to fail to build again, but while I fix them, and you're in the composer.json file, feel free to add yourself to the authors key :)

hendrikheil commented 2 years ago

Finally some public contributions besides fixing typos and updating docs :fire: :-)

hendrikheil commented 2 years ago

@withinboredom Same here, just added my signature so should be ready for merging.