search

dapr / php-sdk

Dapr SDK for PHP
Apache License 2.0
72 stars 15 forks source link

Optimize actor cache #62

Closed withinboredom closed 3 years ago

withinboredom commented 3 years ago

Description

Optimizes the actor cache and reduces duplication of data.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #60

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-io commented 3 years ago

Codecov Report

Merging #62 (7df2dd8) into main (1db57c1) will increase coverage by 0.06%. The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #62      +/-   ##
============================================
+ Coverage     73.56%   73.62%   +0.06%     
+ Complexity      385      379       -6     
============================================
  Files            47       47              
  Lines          1407     1399       -8     
============================================
- Hits           1035     1030       -5     
+ Misses          372      369       -3
Impacted Files Coverage Δ Complexity Δ
src/lib/State/Internal/Transaction.php 100.00% <ø> (ø) 5.00 <0.00> (ø)
src/lib/State/TransactionalState.php 94.44% <60.00%> (-5.56%) 17.00 <0.00> (+2.00) :arrow_down:
src/lib/Actors/ActorState.php 91.93% <87.50%> (+0.04%) 18.00 <2.00> (-7.00) :arrow_up:
src/lib/Actors/Internal/Caches/MemoryCache.php 92.85% <88.88%> (ø) 8.00 <3.00> (?)
src/lib/Actors/Internal/Caches/FileCache.php 96.96% <96.42%> (+8.08%) 14.00 <11.00> (+1.00)
src/lib/Actors/ActorRuntime.php 98.80% <100.00%> (+2.84%) 26.00 <0.00> (-5.00) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1db57c1...7df2dd8. Read the comment docs.