search

dapr / php-sdk

Dapr SDK for PHP
Apache License 2.0
72 stars 15 forks source link

Properly read etags from GET responses #92

Closed withinboredom closed 3 years ago

withinboredom commented 3 years ago

Description

GET responses weren't setting the etag correctly

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-commenter commented 3 years ago

Codecov Report

Merging #92 (1a12d9c) into main (8c6dda2) will decrease coverage by 0.15%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #92      +/-   ##
============================================
- Coverage     73.76%   73.61%   -0.16%     
  Complexity      396      396              
============================================
  Files            49       49              
  Lines          1456     1459       +3     
============================================
  Hits           1074     1074              
- Misses          382      385       +3
Impacted Files Coverage Δ Complexity Δ
src/lib/DaprClient.php 0.00% <0.00%> (ø) 18.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c6dda2...1a12d9c. Read the comment docs.