codecov-commenter
commented
3 years ago Codecov Report
Merging #98 (ab96eb6) into main (57efb04) will decrease coverage by
1.65%. The diff coverage is33.75%.
@@ Coverage Diff @@
## main #98 +/- ##
============================================
- Coverage 68.36% 66.70% -1.66%
- Complexity 448 455 +7
============================================
Files 59 59
Lines 1571 1682 +111
============================================
+ Hits 1074 1122 +48
- Misses 497 560 +63 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/index.php | 0.00% <0.00%> (ø) |
|
| src/lib/Client/PromiseHandlingTrait.php | 57.14% <0.00%> (+57.14%) |
:arrow_up: |
| src/lib/PubSub/Publish.php | 100.00% <ø> (ø) |
|
| src/lib/PubSub/Topic.php | 85.00% <81.25%> (-15.00%) |
:arrow_down: |
| src/config.php | 100.00% <100.00%> (ø) |
|
| src/lib/Client/DaprClient.php | 53.84% <100.00%> (+53.84%) |
:arrow_up: |
| src/lib/Client/DaprClientBuilder.php | 46.66% <100.00%> (+46.66%) |
:arrow_up: |
| src/lib/Client/DaprHttpClient.php | 83.33% <100.00%> (+83.33%) |
:arrow_up: |
| src/lib/Client/HttpPubSubTrait.php | 100.00% <100.00%> (+100.00%) |
:arrow_up: |
| src/lib/Client/HttpStateTrait.php | 0.00% <0.00%> (ø) |
|
| ... and 8 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 57efb04...ab96eb6. Read the comment docs.
Description
This updates pubsub to use the new client.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue: #36
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: