search

dapr / proposals

Proposals for new features in Dapr
Apache License 2.0
15 stars 33 forks source link

Proposal: Unify the DAPR_API_TOKEN env variable across all SDKs #38

Closed elena-kolevska closed 12 months ago

artursouza commented 1 year ago

+1 binding

mukundansundar commented 1 year ago

+1 binding

yaron2 commented 1 year ago

+1 binding

artursouza commented 1 year ago

@elena-kolevska Please, update your commit with "-s"

elena-kolevska commented 1 year ago

@artursouza I thought I did. I do see "Signed-off-by: Elena Kolevska elena@kolevska.com" and the DCO check is passing. Am I missing anything?

shubham1172 commented 1 year ago

+1 binding

berndverst commented 1 year ago

+1 binding

artursouza commented 1 year ago

@artursouza I thought I did. I do see "Signed-off-by: Elena Kolevska elena@kolevska.com" and the DCO check is passing. Am I missing anything?

This might be a wrong requirement in this repo that is asking for cryptographically signed commits. Let me remove that since we don't have that requirement anywhere. Thanks.

kendallroden commented 1 year ago

Agree this will really help standardize the SDKs and remove confusion for customers on proper client initialization requirements +1

elena-kolevska commented 12 months ago

Thanks everyone. Can we proceed to merging this?

yaron2 commented 12 months ago

Thanks everyone. Can we proceed to merging this?

Yes, this proposal can be merged now.