Closed dasanind closed 9 months ago
@dasanind Thanks for the contribution. Welcome to the community. Can you check the issues with the examples and build?
@mukundansundar Can you please approve the build?
@dasanind I'm the maintainer of the repo. Can you please tell me which version of grpctools you used? I'd like the protos to be generated with at least version 1.54.0
or higher. I see a lot of differences in the generates protos here that should not exist, so please check the version.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7beb160
) 86.16% compared to head (614d286
) 86.16%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I pushed a commit with the latest generated protos using 1.60.0 tools.
Technically this PR does not address #617 because that issue itself requires no action. We did not expose the RenameActorReminder in any way.
Everything Actor related in the Python SDK uses HTTP - not protos. See clients/http/dapr_actor_http_client.py
.
But we have to updates protos ahead of each Dapr release anyway. So I'll merge this PR so it can count as a contribution for you.
Thank you @berndverst
Signed-off-by: Anindita Das dasanuiit@gmail.com
Description
Remove deprecated RenameActorReminder methods
Issue reference
Fixes #617
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: