search

dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
222 stars 125 forks source link

[FEATURE REQUEST] Support Cascade Terminate/Purge feature for Dapr Workflow #661

Closed shivamkm07 closed 7 months ago

shivamkm07 commented 8 months ago

Describe the feature

Cascade terminate/purge feature for workflow has been added in Dapr runtime. It is enabled by default and can be disabled by passing non_recursive=True in the terminate/purge request.

SDK needs to expose this option to customer.

Reference:

  1. https://github.com/dapr/dapr/pull/7340
  2. https://github.com/microsoft/durabletask-go/pull/47
  3. https://github.com/microsoft/durabletask-python/pull/27

Release Note

RELEASE NOTE:

shivamkm07 commented 8 months ago

/assign

berndverst commented 7 months ago

Never mind - ignore my comment. I see this is a feature for workflow that must go into the core SDK.

Keep in mind that we are 2 days beyond code freeze. Please have your PR ready (all feedback addressed etc) next week to ensure this will be in the next SDK release.

shivamkm07 commented 7 months ago

Never mind - ignore my comment. I see this is a feature for workflow that must go into the core SDK.

Keep in mind that we are 2 days beyond code freeze. Please have your PR ready (all feedback addressed etc) next week to ensure this will be in the next SDK release.

@berndverst The PR is updated and open for review now. Please take a look at it.