search

dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
230 stars 128 forks source link

Adds error handling for the async client #671

Closed elena-kolevska closed 8 months ago

elena-kolevska commented 8 months ago

Description

Continuation of https://github.com/dapr/python-sdk/pull/659 for the async client.

Issue reference

https://github.com/dapr/python-sdk/issues/648

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fc0e9d1) 86.37% compared to head (cbc54ea) 86.36%. Report is 3 commits behind head on main.

:exclamation: Current head cbc54ea differs from pull request most recent head 6148bca. Consider uploading reports for the commit 6148bca to get more accurate results

Files Patch % Lines
dapr/aio/clients/grpc/client.py 91.83% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #671 +/- ## ========================================== - Coverage 86.37% 86.36% -0.01% ========================================== Files 79 79 Lines 4094 4121 +27 ========================================== + Hits 3536 3559 +23 - Misses 558 562 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elena-kolevska commented 8 months ago

@berndverst the python 3.11 run passes now, after having merged main. We should be good to go.

berndverst commented 8 months ago

@elena-kolevska that makes no sense, but I'll take it :D