dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
221 stars 125 forks source link

fix: convert DAPR_HEALTH_TIMEOUT to float #692

Closed KentHsu closed 3 months ago

KentHsu commented 4 months ago

Description

Convert settings.DAPR_HEALTH_TIMEOUT from str to float Update DaprHealthCheckTests mock so the test can catch this error

Issue reference

Fixes #688 [BUG] DAPR_HEALTH_TIMEOUT as environment variable is not converted to numerical value

Please reference the issue this PR will close: #[#688]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.28%. Comparing base (fc0e9d1) to head (2243cbe). Report is 17 commits behind head on main.

:exclamation: Current head 2243cbe differs from pull request most recent head 9ea041a. Consider uploading reports for the commit 9ea041a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #692 +/- ## ========================================== - Coverage 86.37% 86.28% -0.09% ========================================== Files 79 82 +3 Lines 4094 4172 +78 ========================================== + Hits 3536 3600 +64 - Misses 558 572 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KentHsu commented 4 months ago

Thank you for reviewing this PR @elena-kolevska I update the timeout value to 2.5 and also update the assertion to match this change. Please let me know if there's anything you think we need to update. Thanks!

elena-kolevska commented 4 months ago

Thanks! LGTM now.