Closed KentHsu closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.28%. Comparing base (
fc0e9d1
) to head (2243cbe
). Report is 17 commits behind head on main.:exclamation: Current head 2243cbe differs from pull request most recent head 9ea041a. Consider uploading reports for the commit 9ea041a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for reviewing this PR @elena-kolevska I update the timeout value to 2.5 and also update the assertion to match this change. Please let me know if there's anything you think we need to update. Thanks!
Thanks! LGTM now.
Description
Convert settings.DAPR_HEALTH_TIMEOUT from str to float Update DaprHealthCheckTests mock so the test can catch this error
Issue reference
Fixes #688 [BUG] DAPR_HEALTH_TIMEOUT as environment variable is not converted to numerical value
Please reference the issue this PR will close: #[#688]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: