search

dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
221 stars 125 forks source link

[Snyk] Security upgrade aiohttp from 3.8.6 to 3.9.4 #708

Closed artursouza closed 3 months ago

artursouza commented 3 months ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - examples/workflow/requirements.txt #### Vulnerabilities that will be fixed ##### By pinning: Severity | Priority Score (*) | Issue | Upgrade | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:-------------------------|:------------------------- ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | **661/1000**
**Why?** Recently disclosed, Has a fix available, CVSS 7.5 | Infinite loop
[SNYK-PYTHON-AIOHTTP-6808823](https://snyk.io/vuln/SNYK-PYTHON-AIOHTTP-6808823) | `aiohttp:`
`3.8.6 -> 3.9.4`
| No | No Known Exploit (*) Note that the real score may have changed since the PR was raised. Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded. Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: 🧐 [View latest project report](https://app.snyk.io/org/dapr/project/7c5643c9-b6dd-4708-8c30-ef7a64a8e170?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/dapr/project/7c5643c9-b6dd-4708-8c30-ef7a64a8e170?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"a98106a8-9d47-46ba-8845-e66207dd91ad","prPublicId":"a98106a8-9d47-46ba-8845-e66207dd91ad","dependencies":[{"name":"aiohttp","from":"3.8.6","to":"3.9.4"}],"packageManager":"pip","projectPublicId":"7c5643c9-b6dd-4708-8c30-ef7a64a8e170","projectUrl":"https://app.snyk.io/org/dapr/project/7c5643c9-b6dd-4708-8c30-ef7a64a8e170?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-PYTHON-AIOHTTP-6808823"],"upgrade":[],"isBreakingChange":false,"env":"prod","prType":"fix","templateVariants":["updated-fix-title","priorityScore"],"priorityScoreList":[661],"remediationStrategy":"vuln"}) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Learn about vulnerability in an interactive lesson of Snyk Learn.](https://learn.snyk.io/?loc=fix-pr)
berndverst commented 3 months ago

Not necessary, but pinned some versions that will also address this here: https://github.com/dapr/python-sdk/pull/715

berndverst commented 3 months ago

Technically this is also a false positive:

Here dapr-ext-workflow>=0.1 was listed which imports some dapr version without upper limit. And dapr itself did not force a aiohttp limit either. So aiohttp should have been automatically installed at a sufficiently high version to avoid the security issue.

Perhaps the security scanning tool ran before Github had the library in its Python pip cache.

Either way, it shouldn't occur anymore and for good measure I pinned some versions in the dependency change.

I don't want to force high versions of very common libraries because Python cannot handle installing two versions of the same library in parallel! (Unlike Java etc)