dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
221 stars 125 forks source link

[Snyk] Security upgrade werkzeug from 2.2.3 to 3.0.3 #709

Closed artursouza closed 3 months ago

artursouza commented 3 months ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - dev-requirements.txt
⚠️ Warning ``` virtualenv 20.26.1 has requirement importlib-metadata>=6.6; python_version < "3.8", but you have importlib-metadata 4.2.0. tox 4.8.0 has requirement importlib-metadata>=6.7; python_version < "3.8", but you have importlib-metadata 4.2.0. opentelemetry-api 1.22.0 has requirement importlib-metadata<7.0,>=6.0, but you have importlib-metadata 4.2.0. Flask 2.2.5 requires Werkzeug, which is not installed. ```
#### Vulnerabilities that will be fixed ##### By pinning: Severity | Priority Score (*) | Issue | Upgrade | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:-------------------------|:------------------------- ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | **661/1000**
**Why?** Recently disclosed, Has a fix available, CVSS 7.5 | Remote Code Execution (RCE)
[SNYK-PYTHON-WERKZEUG-6808933](https://snyk.io/vuln/SNYK-PYTHON-WERKZEUG-6808933) | `werkzeug:`
`2.2.3 -> 3.0.3`
| No | No Known Exploit (*) Note that the real score may have changed since the PR was raised. Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded. Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: 🧐 [View latest project report](https://app.snyk.io/org/dapr/project/b6bc485b-4185-4383-8ec8-cbb14b118f66?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/dapr/project/b6bc485b-4185-4383-8ec8-cbb14b118f66?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"c25bb975-1a40-48d9-9b8b-097ea8d073d8","prPublicId":"c25bb975-1a40-48d9-9b8b-097ea8d073d8","dependencies":[{"name":"werkzeug","from":"2.2.3","to":"3.0.3"}],"packageManager":"pip","projectPublicId":"b6bc485b-4185-4383-8ec8-cbb14b118f66","projectUrl":"https://app.snyk.io/org/dapr/project/b6bc485b-4185-4383-8ec8-cbb14b118f66?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-PYTHON-WERKZEUG-6808933"],"upgrade":[],"isBreakingChange":false,"env":"prod","prType":"fix","templateVariants":["updated-fix-title","pr-warning-shown","priorityScore"],"priorityScoreList":[661],"remediationStrategy":"vuln"}) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Remote Code Execution (RCE)](https://learn.snyk.io/lesson/malicious-code-injection/?loc=fix-pr)
berndverst commented 3 months ago

@artursouza if you open these automated PRs, please do make sure the commits are signed.

berndverst commented 3 months ago

This PR is not necessary and I think this is a false positive.

Try:

pip3 uninstall Flask --yes
pip3 uninstall Werkzeug --yes

then

pip3 install Flask>=1.0
pip3 freeze

You will see that the latest Flask gets installed with Werkzeug==3.0.3 which the CVE requests.

Therefore Dapr does not need to force the version since we don't force a maximum Flask version either.

Closing this issue here as a false positive.

berndverst commented 3 months ago

Probably was a caching problem before.