dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
221 stars 125 forks source link

doc: document that users can self-assign issues #712

Closed KentHsu closed 2 months ago

KentHsu commented 3 months ago

Description

Refer to js-sdk, informs users about the GitHub daprbot commands available in the repo with doc link.

Issue reference

Please reference the issue this PR will close: #602

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

elena-kolevska commented 3 months ago

Thanks Kent! I think we should move the new paragraph at the end of the doc, though, because it doesn't read very well in continuation with the sentence before it ("When contributing to the Python SDK the following rules and best-practices should be followed").

I also think we should add the same paragraph in the README.md file, where most developers would probably look first. You can add it after "Generate gRPC Protobuf client" and before "Help & Feedback".

berndverst commented 3 months ago

@elena-kolevska instead of directly in the Readme file I think it should be in Contributing.md

As for the docs, I agree with you on the order.

KentHsu commented 3 months ago

I movedthe new paragraph to the end of python-contributing.md and decide to add the same paragraph in CONTRIBUTING.md. Please let me know if there are other documentations you want to update.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.35%. Comparing base (fc0e9d1) to head (6d798bc). Report is 23 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #712 +/- ## ========================================== - Coverage 86.37% 86.35% -0.02% ========================================== Files 79 82 +3 Lines 4094 4193 +99 ========================================== + Hits 3536 3621 +85 - Misses 558 572 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.