Closed KentHsu closed 1 month ago
Thank you very much for the PR Kent, I'll try to get to it asap.
This PR should address the linter failing: https://github.com/dapr/python-sdk/pull/725
@KentHsu we are beyond code freeze - are you able to address the comments from @elena-kolevska by end of next week? Otherwise, this is unfortunately going to miss the 1.14 release of the SDK.
Currently seeing type check failures as well.
I recommend running the above mentioned commands to resolve type check, lint, autoformatting etc
Hi @berndverst, @elena-kolevska, Thank you for reviewing this PR. I just added some commits to address @elena-kolevska's comments. Please let me know if there's anything you would like to change. Hopefully we can make this PR into the 1.14 release.
Attention: Patch coverage is 96.75676%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 86.59%. Comparing base (
fc0e9d1
) to head (048d0c1
). Report is 29 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Implement below in Dapr gRPC client
Implement below in Dapr gRPC aio client
Add cryptography examples follow go-sdk crypto example
Issue reference
Please reference the issue this PR will close: #548
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: