dapr / python-sdk

Dapr SDK for Python

Apache License 2.0

221 stars 125 forks source link

Implement support for cryptography api #719

Closed KentHsu closed 1 month ago

KentHsu commented 3 months ago

Description

Implement below in Dapr gRPC client
- encrypt/decrypt request iterator and response generator and add tests
- encrypt/decrypt methods in grpc client and add tests
Implement below in Dapr gRPC aio client
- encrypt/decrypt request asynchronous iterator and response asynchronous generator and add tests
- encrypt/decrypt methods in grpc aio client and add tests
Add cryptography examples follow go-sdk crypto example

Issue reference

Please reference the issue this PR will close: #548

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

[X] Code compiles correctly
[X] Created/updated tests
[X] Extended the documentation

elena-kolevska commented 2 months ago

Thank you very much for the PR Kent, I'll try to get to it asap.

elena-kolevska commented 2 months ago

This PR should address the linter failing: https://github.com/dapr/python-sdk/pull/725

berndverst commented 2 months ago

@KentHsu we are beyond code freeze - are you able to address the comments from @elena-kolevska by end of next week? Otherwise, this is unfortunately going to miss the 1.14 release of the SDK.

berndverst commented 2 months ago

Currently seeing type check failures as well.

I recommend running the above mentioned commands to resolve type check, lint, autoformatting etc

KentHsu commented 2 months ago

Hi @berndverst, @elena-kolevska, Thank you for reviewing this PR. I just added some commits to address @elena-kolevska's comments. Please let me know if there's anything you would like to change. Hopefully we can make this PR into the 1.14 release.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.75676% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.59%. Comparing base (fc0e9d1) to head (048d0c1). Report is 29 commits behind head on main.

Files	Patch %	Lines
dapr/aio/clients/grpc/_request.py	95.23%	2 Missing :warning:
dapr/clients/grpc/_request.py	94.87%	2 Missing :warning:
dapr/aio/clients/grpc/_response.py	96.66%	1 Missing :warning:
dapr/clients/grpc/_response.py	96.42%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #719 +/- ## ========================================== + Coverage 86.37% 86.59% +0.22% ========================================== Files 79 84 +5 Lines 4094 4467 +373 ========================================== + Hits 3536 3868 +332 - Misses 558 599 +41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.