search

dapr / python-sdk

Dapr SDK for Python
Apache License 2.0
232 stars 127 forks source link

Makes streaming Subscription iterable #751

Closed elena-kolevska closed 1 week ago

elena-kolevska commented 2 weeks ago

Description

As agreed in the original bidirectional streaming PR, I'm making the sync and async Subscription objects iterable.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.03%. Comparing base (bffb749) to head (6c85263). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
dapr/aio/clients/grpc/client.py 0.00% 6 Missing :warning:
dapr/aio/clients/grpc/subscription.py 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ========================================== - Coverage 86.63% 86.03% -0.60% ========================================== Files 84 87 +3 Lines 4473 4783 +310 ========================================== + Hits 3875 4115 +240 - Misses 598 668 +70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elena-kolevska commented 2 weeks ago

Should close https://github.com/dapr/python-sdk/issues/730