dapr / quickstarts

Dapr quickstart code samples and tutorials showcasing core Dapr capabilities
Apache License 2.0
1.03k stars 523 forks source link

Update tutorials pub-sub csharp-subscriber image to dotnet 8.0 #1001

Closed antontroshin closed 2 months ago

antontroshin commented 6 months ago

Description

Update tutorials pub-sub csharp-subscriber image to dotnet 8.0

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1000

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

paulyuk commented 6 months ago

Hi that's really cool, @antontroshin thank you for the contribution. Does it work well with this change from what you can tell? ready to go? I'm running tests now.

antontroshin commented 6 months ago

I did test this locally, but had to do a few manual changes, due to the image location. Using kind local cluster.

cd tutorials/pub-sub/csharp-subscriber
dotnet restore
dotnet build -o out
docker buildx build -t csharp-subscriber:test .
kind load docker-image csharp-subscriber:test
cd ..

Manually update tutorials/pub-sub/deploy/csharp-subscriber.yaml container image location and imagePullPolicy

...
      containers:
      - name: csharp-subscriber
        image: csharp-subscriber:test
        imagePullPolicy: IfNotPresent
...

Then apply the updated manifest kubectl apply -f deploy/csharp-subscriber.yaml Observe logs

➜  kubectl logs deployments/csharp-subscriber
Defaulted container "csharp-subscriber" out of: csharp-subscriber, daprd
warn: Microsoft.AspNetCore.Server.Kestrel[0]
      Overriding address(es) 'http://*:8080'. Binding to endpoints defined via IConfiguration and/or UseKestrel() instead.
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://localhost:5009
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
      Content root path: /app
marcduiker commented 1 month ago

@holopin-bot @antontroshin Thanks!

holopin-bot[bot] commented 1 month ago

Congratulations @antontroshin, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvbi07105450cl4ketlwwjv

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!