dapr / quickstarts

Dapr quickstart code samples and tutorials showcasing core Dapr capabilities
Apache License 2.0
1.04k stars 526 forks source link

Wrong commands in Hello-Kubernetes Tutorial #944

Open msfussell opened 1 year ago

msfussell commented 1 year ago

Bugs in this tutorial when observing logs for nodeapp https://github.com/dapr/quickstarts/tree/master/tutorials/hello-kubernetes

This kubectl logs --selector=app=node -c node --tail=-1 should be kubectl logs --selector=app=nodeapp -c nodeapp --tail=-1

And this kubectl logs --selector=app=node -c daprd --tail=-1 should be kubectl logs --selector=app=nodeapp -c daprd --tail=-1

And this kubectl logs --selector=app=python -c daprd --tail=-1 should be kubectl logs --selector=app=pythonapp -c daprd --tail=-1

Check any missing occurences in the rest of the tutorial

Titanpimpale commented 1 year ago

Hello @msfussell I would love to make changes to the above tutorial and also if I find any missing occurrence in the project I will fix that also please assign it to me !!!

msfussell commented 1 year ago

Assigned!

dasanind commented 8 months ago

@Titanpimpale Are you working on this?

pdebruin commented 4 months ago

Hi @msfussell, I just looked at this. It looks like this works as is today (and the proposed changes don't). What was the source of this proposed change? Else I suggest to close this issue. Thanks!