dapr / quickstarts

Dapr quickstart code samples and tutorials showcasing core Dapr capabilities
Apache License 2.0
1.03k stars 523 forks source link

Javascript quickstart test failure/regression on dapr run with gprc #998

Closed paulyuk closed 7 months ago

paulyuk commented 7 months ago

the test now fails when you use full release 1.13.0 and dapr run with grpc

repro: https://github.com/paulyuk/quickstarts/blob/release-1.13/configuration/javascript/sdk/README.md?plain=1#L61

 paulyuk@Pauls-MacBook-Pro-2  ~/src/paulyuk/quickstarts/service_invocation/csharp/http   release-1.13  dapr version
CLI version: 1.13.0 
Runtime version: 1.13.0

cd ./order-processor
dapr run --app-id order-processor --resources-path ../../../components/ --app-protocol grpc --dapr-grpc-port 3500 -- node index.js

✅  You're up and running! Both Dapr and your app logs will appear here.

== APP == 2024-03-06T16:24:50.020Z INFO [GRPCClient, GRPCClient] Opening connection to localhost:3599
== APP == 2024-03-06T16:24:50.025Z INFO [GRPCClient, GRPCClient] Awaiting Sidecar to be Started
== APP == Could not get config item, err:Error: DAPR_SIDECAR_COULD_NOT_BE_STARTED
paulyuk commented 7 months ago

Interesting I wonder if this new javascript failure is related: https://github.com/dapr/quickstarts/issues/998

        == APP == /home/runner/work/quickstarts/quickstarts/cryptography/javascript/sdk/crypto-quickstart/node_modules/@dapr/dapr/implementation/Client/DaprClient.js:164
        == APP ==                 throw new Error("DAPR_SIDECAR_COULD_NOT_BE_STARTED");
        == APP ==                       ^
        == APP == 
        == APP == Error: DAPR_SIDECAR_COULD_NOT_BE_STARTED
        == APP ==     at DaprClient.awaitSidecarStarted (/home/runner/work/quickstarts/quickstarts/cryptography/javascript/sdk/crypto-quickstart/node_modules/@dapr/dapr/implementation/Client/DaprClient.js:164:23)
        == APP ==     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
        == APP ==     at async GRPCClient._startAwaitSidecarStarted (/home/runner/work/quickstarts/quickstarts/cryptography/javascript/sdk/crypto-quickstart/node_modules/@dapr/dapr/implementation/Client/GRPCClient/GRPCClient.js:157:9)
        == APP ==     at async GRPCClient.start 
shubham1172 commented 7 months ago

Release has been cut! https://github.com/dapr/js-sdk/releases/tag/v3.3.1 https://www.npmjs.com/package/@dapr/dapr/v/3.3.1

paulyuk commented 7 months ago

Verified and works great. thanks @shubham1172 !

✅  You're up and running! Both Dapr and your app logs will appear here.

== APP == 2024-03-06T21:15:20.250Z INFO [GRPCClient, GRPCClient] Opening connection to localhost:3500
== APP == Configuration for orderId1: {"key":"orderId1","value":"103","version":"","metadata":{}}
== APP == Configuration for orderId2: {"key":"orderId2","value":"104","version":"","metadata":{}}
paulyuk commented 7 months ago

verified