dapr / test-infra

Test apps and tools for Dapr
Apache License 2.0
14 stars 24 forks source link

Run longhaul regular against the release branch #144

Closed tanvigour closed 1 year ago

tanvigour commented 2 years ago

Signed-off-by: tanvigour tanvi.gour@gmail.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #4827

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

tanvigour commented 2 years ago

@halspang :Please review this when you get a chance, thanks

halspang commented 2 years ago

Doesn't this defeat the purpose of the nightly longhaul? I thought we wanted it on master so we could find issues with it before we got to the release time.

tanvigour commented 2 years ago

Doesn't this defeat the purpose of the nightly longhaul? I thought we wanted it on master so we could find issues with it before we got to the release time.

We do have to manually run this against release branch as well to get coverage during release, and so I thought it would be nice to have that qualification as well. Although this change would run against all branches and maybe we should have it tied to only the new release branch per release? what do you think?

halspang commented 2 years ago

During the release we update the regular longhauls to be on the new release while the nightly's tend to stay on master. If you wanted to update the standard longhaul to go off of the release branch (so it updates automatically when we have a new release) I think that'd be a good change. I think the nightly run should be on master though.

tanvigour commented 2 years ago

@halspang : Please review when you get a chance, Thanks!