search

dapriett / nativescript-google-maps-sdk

Cross Platform Google Maps SDK for Nativescript
MIT License
244 stars 164 forks source link

fix: myLocationButton not working on iOS #411

Closed Log3n closed 2 years ago

Log3n commented 4 years ago

Closes #375 identical fix as PR #369

fix: return true in didTapMyLocationButtonForMapView prevents the default behavior of the myLocationButton. So, the map does not move to myLocation on Tap.

sebalopezz commented 4 years ago

@dapriett can you take a look at this PR. The button does not work to get the current location in iOS, as mentioned. @Log3n 's fix is correct. The only thing that does not look good on the screen is that the current position is not centered, but is in the upper left corner. Do you have any way to fix this? Thank you

MrSnoozles commented 4 years ago

Confirming too, @Log3n s fix worked. @dapriett Would be nice to have this merged, this tiny issue took us way longer to figure out than I'd like to admit.

Log3n commented 2 years ago

This fix has been included in 3.0.2 with #446