dapriett / nativescript-google-maps-sdk

Cross Platform Google Maps SDK for Nativescript
MIT License
244 stars 164 forks source link

Nativescript 7.x compatibility - Markers not showing #422

Open funder7 opened 4 years ago

funder7 commented 4 years ago

Hello,

I've created a PR which is built around the new nativescript libraries (@nativescript/x).

Actually this has been tested on Android (emulator), a test on iOS would be nice in case the changes will be approved.

PR #420

@dapriett can you check it? thanks :) (Please read the last message in the PR, there's one major problem that must be fixed prior to merging)

alexisconsuegra commented 4 years ago

Hi @funder7 . Is this plugin been maintained at all? I see lots of open issues with out a response. I noticed the marker is no longer showing also. I just posted one issue a few days ago. I am trying to build ios with xCode 10.1.0 but it fails. Have you been able to do local builds? Thanks, Alexis

Undefined symbols for architecture i386: "___isPlatformVersionAtLeast", referenced from: -[GMSCellularInfo SIMCountryCode] in GoogleMaps -[GMSScreenInfo initWithUIScreen:] in GoogleMaps -[GMSx_QTMCollectionViewController viewDidLoad] in GoogleMaps -[GMSx_QTMCollectionViewController viewDidLayoutSubviews] in GoogleMaps -[GMSx_QTMCollectionViewStyleController contentViewInsetsForCellWithAttribute:] in GoogleMaps -[GMSx_QTMCollectionViewStyleController setInsetsContentViewsToSafeArea:] in GoogleMaps -[GMSx_QTMCollectionViewStyleController insetsAtSectionIndex:] in GoogleMaps ... ld: symbol(s) not found for architecture i386 clang: error: linker command failed with exit code 1 (use -v to see invocation) note: Using new build systemnote: Planning buildnote: Constructing build description BUILD FAILED

Command xcodebuild failed with exit code 65

funder7 commented 4 years ago

Hi, @alexisconsuegra, I don't know what are the author's intentions about this, I'm waiting for a reply too.. About your problem, let's continue the discussion in your issue!

flocca commented 4 years ago

Same problem here, markers not showing. Any workaround?

funder7 commented 3 years ago

I have the fix, I'll push it tomorrow

flocca commented 3 years ago

Thank you @funder7, I can't wait to try your fix.

funder7 commented 3 years ago

Hi @flocca sorry but I had some delay, I'll push the changes this weekend hopefully.

ubaidazad commented 3 years ago

after upgrading to 7.x MapView is not showing map at all, it was working in 6.x address image

funder7 commented 3 years ago

Hello @ubaidazad thanks for reporting it. I will definitively check it this weekend to see if I can make it be compatible with the latest {N} version.

ubaidazad commented 3 years ago

any progress here?

postescu commented 3 years ago

apparently not...

funder7 commented 3 years ago

Sorry guys I'm doing this in my free time, which is inexistent in the last weeks... Probably I'll meet with other people during the next weekend to complete the update.

postescu commented 3 years ago

thank you. we apreciate. there is a PR that looks like it fixes a lot of compat issues... when you have time...
thanks a lot

funder7 commented 3 years ago

after upgrading to 7.x MapView is not showing map at all, it was working in 6.x

@ubaidazad On which platform? Can you try to run on the other one as well and check if is not showing as well? Thanks

funder7 commented 3 years ago

thank you. we apreciate. there is a PR that looks like it fixes a lot of compat issues... when you have time...
thanks a lot

No worries, I wish I had the time to close it now as it doesn't look like there's much to end the update. Which PR are you referring to?

ubaidazad commented 3 years ago

On which platform? Can you try to run on the other one as well and check if is not showing as well? Thanks

@funder7 platform: Android Device What other one are you referring to?