daptiv / dotnetframework

Chef cookbook for installing and configuring .NET framework 4.x
Apache License 2.0
8 stars 20 forks source link

Change min 4.6.1 build number from 01055 to 01038 #34

Closed cpx86 closed 8 years ago

cpx86 commented 8 years ago

On Windows 10, the mini-test fails because the version number is 4.6.1.01038 instead of 4.6.1.01055. I believe this is because Windows 10 comes with .NET 4.6.1 pre-installed, albeit with a slightly lower version number, and the installer does not make any changes to this. To support this, the MSDN article (https://msdn.microsoft.com/en-us/library/hh925568%28v=vs.110%29.aspx#net_b) states that the release number in Windows 10 November Update is 394254, but for all other OS versions it is 394271.

I've tested this on my own box and it works :)

sneal commented 8 years ago

Thanks! Since we only check that the version >=, this should be safe on other OSs too. Although it seems I should look into refactoring the version attributes, because we currently do things like:

if is_2012r2_or_8_1
  default['dotnetframework']['4.5.1']['version'] = '4.5.51641'
else
  default['dotnetframework']['4.5.1']['version'] = '4.5.50938'
end

Semantically we're really saying

default['dotnetframework']['4.5.1']['min_version'] = '4.5.50938'

I wish there was an OS agnostic way to check that a particular version of .NET (e.g. 4.6) is installed.