daq-tools / kotori

A flexible data historian based on InfluxDB, Grafana, MQTT, and more. Free, open, simple.
https://getkotori.org/
GNU Affero General Public License v3.0
107 stars 17 forks source link

DAQ: Mask `PASSKEY` variable coming from HTTP, emitted by Ecowitt #123

Closed amotl closed 1 year ago

amotl commented 1 year ago

Hi there,

in order to support acquiring data from an Ecowitt device ^1, this patch will mask the PASSKEY variable from the ingress data. It should not be part of the measurement readings.

With kind regards, Andreas.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (de224af) 52.67% compared to head (2dd0beb) 52.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ========================================== + Coverage 52.67% 52.69% +0.02% ========================================== Files 99 99 Lines 5221 5224 +3 ========================================== + Hits 2750 2753 +3 Misses 2471 2471 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `52.69% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/daq-tools/kotori/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools) | Coverage Δ | | |---|---|---| | [kotori/io/protocol/http.py](https://codecov.io/gh/daq-tools/kotori/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools#diff-a290b3JpL2lvL3Byb3RvY29sL2h0dHAucHk=) | `82.90% <100.00%> (+0.13%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

amotl commented 1 year ago

Closing this in favor of GH-125.