daq-tools / kotori

A flexible data historian based on InfluxDB, Grafana, MQTT, and more. Free, open, simple.
https://getkotori.org/
GNU Affero General Public License v3.0
107 stars 17 forks source link

[DA] Add per-device addressing (DA) to WAN topic/channel decoding strategy #136

Closed amotl closed 1 year ago

amotl commented 1 year ago

About

This patch implements the proposal outlined at GH-133, adding a generic per-device topic addressing scheme, not exclusively but also in order to bring in multi-tenant TTN support, see GH-8.

Documentation

... is still missing. But reading the code, specifically the test cases and inline comments, will give you an idea.

Details

Backlog

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23 :tada:

Comparison is base (2a0b51c) 53.02% compared to head (d2151b6) 53.26%.

:exclamation: Current head d2151b6 differs from pull request most recent head 1fa3ca5. Consider uploading reports for the commit 1fa3ca5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #136 +/- ## ========================================== + Coverage 53.02% 53.26% +0.23% ========================================== Files 100 100 Lines 5267 5291 +24 ========================================== + Hits 2793 2818 +25 + Misses 2474 2473 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `53.26% <100.00%> (+0.23%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/daq-tools/kotori/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools) | Coverage Δ | | |---|---|---| | [kotori/daq/strategy/wan.py](https://app.codecov.io/gh/daq-tools/kotori/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools#diff-a290b3JpL2RhcS9zdHJhdGVneS93YW4ucHk=) | `100.00% <100.00%> (+3.44%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.