codecov[bot]
commented
1 year ago Codecov Report
Attention: Patch coverage is 89.88764% with 18 lines in your changes missing coverage. Please review.
Project coverage is 78.86%. Comparing base (
90e815a) to head (c30b6ad).:exclamation: Current head c30b6ad differs from pull request most recent head a6d66d5
Please upload reports for the commit a6d66d5 to get more accurate results.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main crate/crate-python#148 +/- ## ========================================== + Coverage 78.59% 78.86% +0.26% ========================================== Files 55 58 +3 Lines 3014 3180 +166 ========================================== + Hits 2369 2508 +139 - Misses 645 672 +27 ``` | [Flag](https://app.codecov.io/gh/daq-tools/kotori/pull/148/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/daq-tools/kotori/pull/148/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools) | `78.86% <89.88%> (+0.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=daq-tools#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
amotl
About
Migrating to InfluxDB version 2 would mean to leave SQL behind ^1. While using the Flux query language is intriguing, and I will not reject bringing in support for InfluxDB2 and its successor IOx, supporting an SQL-based timeseries database makes sense for me, and this time maybe even a more capable one than InfluxDB in terms of broader support for data types and SQL operations.
So, I think viable alternatives are both CrateDB and TimescaleDB [^2], which may even share parts of their corresponding adapter implementations, because both are building upon PostgreSQL standards. This patch makes a start by adding support for CrateDB, let's have a look at TimescaleDB later.
Documentation
https://kotori--148.org.readthedocs.build/en/148/database/cratedb.html
Backlog
max_byandmin_bycould also be utilized in a sensible way.[^2]: With the drawback that TimescaleDB also changed the license for parts of their code to non-FOSS, see https://github.com/timescale/timescaledb/blob/main/tsl/LICENSE-TIMESCALE.