Use template specializations to avoid shift warnings.

daqana / dqrng

Fast Pseudo Random Number Generators for R

https://daqana.github.io/dqrng/

Other

42 stars 8 forks source link

Use template specializations to avoid shift warnings. #16

Closed LTLA closed 5 years ago

LTLA commented 5 years ago

May (or may not) address the segfault observed in #15.

rstub commented 5 years ago

It feels weird having to define these template specializations even though they will never be called. I tried to get rid of the compiler warnings using tag dispatch on shiftable. But the there was lots of code duplication between the true and falsecases.

rstub commented 5 years ago

BTW, since we know that these four template specializations will never be called, can you please add // # nocov to the end of those lines? that way the error from the codecov check should go away.