daranzolin / rcanvas

R Client for Canvas LMS API
Other
90 stars 43 forks source link

get_course_gradebook error #51

Open Kuipermatthijs opened 3 years ago

Kuipermatthijs commented 3 years ago

Hi,

first of all, love the work, and with this API we could manage to build a Shiny board to have an overview of our whole curriculum.

However I now run into an error with the get_course_gradebook()

get_coursegradebook(10633) `mutate()is deprecated as of dplyr 0.7.0. Please usemutate()instead. See vignette('programming') for more help This warning is displayed once every 8 hours. Calllifecycle::lastwarnings()` to see where this warning was generated.Error in UseMethod("mutate") : no applicable method for 'mutate_' applied to an object of class "list"

I could create an instance where i still have dplyr 0.7.0, though would it be possible to have this as a fix?

Kuipermatthijs commented 3 years ago

In addition, I did try to roll back to R version 3.3.0, however, that is obsolete with RStudio (current version). Roll back to dplyr 0.5.0 did not work, as rlang would not be compatible.

If there is something I can do to help, please let me know.

daranzolin commented 3 years ago

Ah, bad timing for the end of the semester! Unfortunately, I'm no longer an active maintainer on this project, so if you want to get involved and submit a pull request, it would be more than welcomed. There are also a handful of other awesome maintainers, so maybe someone else will chime in.

rmtrane commented 3 years ago

I ran into this same problem earlier today. It seems that it is not necessarily related to mutate_ being deprecated (not sure why this shows up), but rather a problem in the process_response function. It seems that this one is easily fixed by using dplyr::bind_rows(d) rather than purr::flatten_df to create the data.frame.

I did also encounter a different issue where the first page wouldn't be downloaded in the paginate function. I also think I have an ad-hoc fix for this.

I'm not familiar with this package or the source code in general, so I don't know how well these fixes generalize, but I can share if you are interested.

Edit: you can find my forked repo with two changes here: https://github.com/rmtrane/rcanvas.

Kuipermatthijs commented 3 years ago

I'll have a look at your updates tomorrow. I found the error already somewhat off, somewhere i recall it from earlier days. Though i am not sure how i fixed it.

roll back has failed, there have been to many updates since june 2016 to make it run stable.

jtr13 commented 3 years ago

@rmtrane Your edits worked for me... maybe submit a PR?