daraosn / node-zip

217 stars 38 forks source link

Please avoid using global object for exporting any stutf #16

Open escaton opened 8 years ago

daraosn commented 8 years ago

I made this repository some years ago, when there wasn't any Node.js zip library. I found the project JSZip, they made a great job porting zip/unzip archiving functionality, but it used to work only on browsers. That's why I made this repo, but now things have changed and JSZip I think it works with node, but this module is used at many projects (I didn't expect this to be honest).

Accepting your pull request could potentially break many dependent projects that rely on this functionality (we could think on a version bump maybe).

I would rather wait a bit and ask to see if more people are okay with the change.

trufae commented 8 years ago

just bump the big version number and projects should carefully upgrade. breaking api shouldnt be a problem if proper documentation is provided, and this change is trivial