search

daraosn / node-zip

217 stars 38 forks source link

Please upgrade the JSZip version #2

Closed feugy closed 11 years ago

feugy commented 11 years ago

Hi !

I found and fixed an annoying bug in JSZip (generated files cannot be read with any Java programs).

Can you please update your JSZip version ? you'll find the fixed version on https://github.com/feugy/jszip/, and (I hope soon) in https://github.com/Stuk/jszip.

Thank you !

Mithgol commented 11 years ago

If I were you, I'd have created a pull request.

Mithgol commented 11 years ago

You could have used your Stuk/jszip#33 as the source.

feugy commented 11 years ago

Sorry, I did not knew it was possible. So, once this pull request will be accepted, is it possible that you integrate it and publish a new version on NPM ?

Mithgol commented 11 years ago

You overestimate the importance of my suggestion. I do not have any relation to node-zip. I am a mere passerby. Sorry.

daraosn commented 11 years ago

Hey, thanks for reporting. As this is only a port to JSZip, I would like to wait until we have a final reaction from Stuk/jszip. After they test and implement your patch, I will update node-zip.