darbyjohnston / DJV

Professional media review software for VFX, animation, and film production
https://darbyjohnston.github.io/DJV/
BSD 3-Clause "New" or "Revised" License
678 stars 59 forks source link

Color picker gives wrong values for 8-bit grayscale images #304

Open net147 opened 4 years ago

net147 commented 4 years ago

Picking black gives Color 1, picking white gives Color 254.

darbyjohnston commented 4 years ago

Hi, could you try unchecking the "Apply color space" option in the color picker and see if that fixes the issue? I think that the color space transforms may be causing some inaccuracy,

DJV Color Picker

net147 commented 4 years ago

@darbyjohnston I only see "Lock color type" in that menu. I am using DJV 2.0.6 on Linux. The color type is "L U8".

darbyjohnston commented 4 years ago

That feature was added in the most recent version; I would recommend upgrading, there are also a number of important bug fixes. You can download it here:

https://darbyjohnston.github.io/DJV/download.html

net147 commented 4 years ago

@darbyjohnston Unchecking "Apply color space" in DJV 2.0.8 gives the correct values.

darbyjohnston commented 4 years ago

I believe the next version of OpenColorIO will have improved accuracy, I hope to upgrade when it is available.

darbyjohnston commented 3 years ago

I've added a new issue for upgrading OpenColorIO: https://github.com/darbyjohnston/DJV/issues/343