search

darchr / parsec-benchmark

Other
15 stars 9 forks source link

Make splash2x.raytrace GCC-10 compatible #3

Closed 64kramsystem closed 3 years ago

64kramsystem commented 3 years ago

Fix the issue described in #2 - splash2x.raytrace requiring the common model, which is not the default anymore from GCC 10 onwards.

I think at least another package has the same problem, but can't remember which one; I'm marking this as Closes #2 nonetheless.

I don't know if splash2.raytrace should be fixed as well or not, since from the README, I gather that it's not really clear what's its purpose.

64kramsystem commented 3 years ago

(closed accidentally; reopened)

64kramsystem commented 3 years ago

Excellent!

I've found the other benchmark that requires the same change, so it could be the right time to add it. The commit is in my fork: https://github.com/saveriomiroddi/parsec-benchmark-tweaked/commit/b00b06e4669e456c7eedbf149d1c375c7b3e7267.

Let me know if I should open a new PR (becase the branch for this PR has a specific name, sav/make_splash2x_raytrace_gcc_10_compatible), or I can cherry pick it in (that is, branch name is no problem).

mahyarsamani commented 3 years ago

I applied the patch and successfully built splash2x.raytrace with gcc-10.2.0.

mahyarsamani commented 3 years ago

I applied the patch and successfully built splash2x.raytrace with gcc-10.2.0.

@saveriomiroddi Thank you for your contribution