search

darcyclarke / Repo.js

:page_facing_up: A plugin to embed Github repos on your site
MIT License
911 stars 82 forks source link

Clicking the repo name first causes the embedded repo to disappear #1

Closed kborchers closed 12 years ago

kborchers commented 12 years ago

If you click the repo name before clicking any file in the repo, the embedded repo disappears. Clicking the repo name after clicking any file works as expected sending you back to the top level of the repo and clicking again does not make the repo disappear.

darcyclarke commented 12 years ago

Hot jam, I will fix tonight unless you want to take a stab at it ;)

fuzenco commented 12 years ago

On Safari (5.1.7), clicking on the repo name after clicking a repo content does not take you back to the root level. Instead, the repo disappears.

Awesome plugin though!

wpgreenway commented 12 years ago

This is a great looking plugin.

I encountered similar problems on the demo site using Chrome 20.0.1132.43. The behavior varies between the three examples. Clicking the repo name in the basic embed causes the repo to disappear. However, everything seems to work completely as expected with the basic embed (with hawt repo) where viewing files, folders, and returning to root all execute correctly. Then with the branch specific embed I'm able to view a file, but clicking on a folder or the repo name causes it to disappear.

MarcusJT commented 12 years ago

+1 (also Chrome)

jasondavis commented 12 years ago

+1 for the Chrome issue as well. Only thing that is stopping me from using this as of right now

franz-josef-kaiser commented 12 years ago

+1 on Chrome

kborchers commented 12 years ago

So, I went to dig into this tonight and I can't reproduce the issue in a simplified test case. http://jsfiddle.net/bnPCN/

This may just be an issue with something on the home/demo page. Anyone else able to reproduce?

jasondavis commented 12 years ago

@kborchers Were you able to see the problem on the test/demo page? On that page it happens on the first Demo repo.js

I will also play around and see if I can reproduce on other stuff

kborchers commented 12 years ago

@jasondavis Yes, I see it on the demo page (which caused me to report the issue) but I am unable to reproduce it outside of that page.