search

darcyclarke / Repo.js

:page_facing_up: A plugin to embed Github repos on your site
MIT License
911 stars 82 forks source link

Line-specific links don't work #17

Open brockboland opened 12 years ago

brockboland commented 12 years ago

I was playing with the demo and noticed this: click into a text file. Click on a line number. Like on Github, the line is highlighted, and the line number added to the URL, perhaps like this:

http://darcyclarke.me/dev/repojs/#vg-4:{20}

However, that link won't actually refer to that line, if (for example) you share it with a coworker.

darcyclarke commented 12 years ago

Definitely want to get this working. I know it would be awesome to share specific files/lines of code from your own embedded repo on your site to co-workers etc..

The anchors that are made when you click a line in a file are done by the Vangogh library that comes with Repo.js. That functionality is going to have to change, which means I'll have to do work on the Vangogh library to be more custom. I may reach out to mekwall, the creator, for more support on that.

Essentially, this feature would be considered "deep-linking" and issues #5 and #7 need to be dealt with to make this work as well. So I'll hit those up first.