darekf77 / ng2-logger

Isomorphic logger for Browser and NodeJS, ( typescript / javascript ) apps
MIT License
61 stars 17 forks source link

ng lint errors with angular cli 1.0.0 #22

Closed osixia closed 7 years ago

osixia commented 7 years ago

Hello, with angular cli 1.0.0 ng lint returns some "errors":

[...]/node_modules/ng2-logger/src/display.ts[10, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/display.ts[11, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/display.ts[12, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/display.ts[14, 13]: Identifier 'a1' is never reassigned; use 'const' instead of 'let'.
[...]/node_modules/ng2-logger/src/display.ts[15, 13]: Identifier 'a2' is never reassigned; use 'const' instead of 'let'.
[...]/node_modules/ng2-logger/src/display.ts[16, 13]: Identifier 'a3' is never reassigned; use 'const' instead of 'let'.
[...]/node_modules/ng2-logger/src/logger.ts[18, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[20, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[21, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[29, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[31, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[32, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[40, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[42, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[43, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[51, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[53, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[54, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[63, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[64, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[66, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[67, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/logger.ts[74, 5]: Declaration of instance field not allowed after declaration of instance method. Instead, this should come after static fields.
[...]/node_modules/ng2-logger/src/logger.ts[80, 5]: Declaration of static field not allowed after declaration of instance method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/logger.ts[80, 37]: Type boolean trivially inferred from a boolean literal, remove type annotation
[...]/node_modules/ng2-logger/src/logger.ts[62, 5]: misplaced opening brace
[...]/node_modules/ng2-logger/src/logger.ts[61, 30]: missing whitespace
[...]/node_modules/ng2-logger/src/logger.ts[61, 44]: missing whitespace
[...]/node_modules/ng2-logger/src/logger.ts[61, 59]: missing whitespace
[...]/node_modules/ng2-logger/src/log.ts[37, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[42, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[64, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[65, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[76, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[81, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[82, 9]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[87, 13]: if statements must be braced
[...]/node_modules/ng2-logger/src/log.ts[57, 5]: Declaration of static field not allowed after declaration of static method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/log.ts[58, 5]: Declaration of static field not allowed after declaration of static method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/log.ts[69, 5]: Declaration of static field not allowed after declaration of static method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/log.ts[70, 5]: Declaration of static field not allowed after declaration of static method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/log.ts[92, 5]: Declaration of static field not allowed after declaration of static method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/log.ts[93, 5]: Declaration of static field not allowed after declaration of static method. Instead, this should come at the beginning of the class/interface.
[...]/node_modules/ng2-logger/src/log.ts[93, 31]: Type boolean trivially inferred from a boolean literal, remove type annotation
[...]/node_modules/ng2-logger/src/log.ts[86, 14]: Forbidden 'var' keyword, use 'let' or 'const' instead
[...]/node_modules/ng2-logger/src/log.ts[88, 49]: Missing semicolon
[...]/node_modules/ng2-logger/src/log.ts[81, 31]: == should be ===
[...]/node_modules/ng2-logger/src/log.ts[80, 45]: missing whitespace
[...]/node_modules/ng2-logger/src/log.ts[80, 53]: missing whitespace
[...]/node_modules/ng2-logger/src/log.ts[81, 11]: missing whitespace
[...]/node_modules/ng2-logger/src/log.ts[82, 11]: missing whitespace
[...]/node_modules/ng2-logger/src/log.ts[87, 15]: missing whitespace
darekf77 commented 7 years ago

Hi, thanks for feedback.. I will use ng lint for new version ( should be ready this week ).

osixia commented 7 years ago

Great thanks :)