search

darekf77 / ng2-logger

Isomorphic logger for Browser and NodeJS, ( typescript / javascript ) apps
MIT License
61 stars 17 forks source link

Warnings from ng9 build #50

Closed CarstenLeue closed 4 years ago

CarstenLeue commented 4 years ago

When pulling in the browser version of ng2-logger in an ng9 ivy build I get this warning:

WARNING in Entry point '@acoustic-content-sdk/ng-logger' contains deep imports into '/usr/build/sites/node_modules/ng2-logger/browser'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

I think this is because ng2-logger/browser does not contain its own package.json file. Could you consider representing ng2-logger/browser using a secondary entry point instead of having to use deep imports?

https://github.com/ng-packagr/ng-packagr/blob/master/docs/secondary-entrypoints.md

darekf77 commented 4 years ago

( Sorry for delay ) Sure... in next version there will be package .json for /browser.

darekf77 commented 4 years ago

Now... from version 3.0.12 there is package.json in browser or client folder.