search

darekkay / dashboard

Customizable personal dashboard and startpage
https://dashboard.darekkay.com
MIT License
187 stars 27 forks source link

Added The TOTD World Country Widget #23

Closed syentix closed 4 years ago

darekkay commented 4 years ago

Closing and re-opening to (hopefully) retrigger TravisCI checks

syentix commented 4 years ago

Really appreciate it :) I'll check out some stuff and maybe look into travis myself never used CI for anything yet

syentix commented 4 years ago

They got retriggered! I had to thumble around and test through travis, since for some reason the linting wouldn't work on my machine. Looks good now!

syentix commented 4 years ago

Btw the random image widget looks great! How did you fix it in the end?

darekkay commented 4 years ago

for some reason the linting wouldn't work on my machine

It should work on any OS (tested on Windows and macOS). Did you run the command from the app subfolder? The repository is a monorepo, so all npm/yarn commands have to be executed from the subdirectories (app and/or server).

Btw the random image widget looks great! How did you fix it in the end?

Thanks 😃 The caption is positioned absolutely, relative to the figure (which has to be full height and full width). The overlay is a simple background-color with an alpha value, so it's partially transparent. The main challenge was finding colors with an accessible contrast ratio.

syentix commented 4 years ago

I did, it just threw an error about no files found with pattern {internals/**.tsx}.

syentix commented 4 years ago

Am i allowed to merge this in?

darekkay commented 4 years ago

Sorry, I've first had a look into the YouTube Stats widget, which is now finished. I will try to check this PR tomorrow :)