search

darenju / react-flip-page

A React.js implementation of the Flipboard page swipe.
MIT License
173 stars 31 forks source link

Flattens children array to allow mapping usage. #144

Closed saricden closed 4 years ago

saricden commented 4 years ago

Related to #143

I noticed that there is a bug (described in the issue), when children of FlipPage are mapped as an array. So I flattened the children prop in all cases it's used so that it behaves as expected.

This solves my original issue posted.

:beers:

codecov[bot] commented 4 years ago

Codecov Report

Merging #144 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   96.72%   96.76%   +0.03%     
==========================================
  Files           4        4              
  Lines         336      340       +4     
  Branches      105      105              
==========================================
+ Hits          325      329       +4     
  Misses         11       11
Impacted Files Coverage Δ
src/index.jsx 98.44% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faddf0c...bea6209. Read the comment docs.

darenju commented 4 years ago

Oh, that’s awesome, if you managed to solve the issue yourself! I was trying to think of what could cause the issue…

Merging.