search

darenliang / mal-api

A local MyAnimeList API
https://mal-api.readthedocs.io
MIT License
47 stars 12 forks source link

Feedback on how to implement search functionality #3

Closed darenliang closed 3 years ago

darenliang commented 4 years ago

Without search, this library is practically useless.

Any feedback on how to implement search functionality is greatly appreciated.

There are a few questions:

  1. How should the response be structured?
  2. How should the search function signature be like?
collinarnett commented 3 years ago

I don't know how useful those 50x70 icons that comes from the search results. I used some regex to give the full sized image from the image url:

re.sub('r\/50x70\/|\\?s=.*','', image_url)
darenliang commented 3 years ago

Sounds good! I'll take a look at it.

collinarnett commented 3 years ago

It would also be great to be able to get the synonyms for the searched manga/anime.

Also I really dig this library, it makes things super easy for me.

darenliang commented 3 years ago

There's still a bunch of fields/attributes that aren't parsed such as staff and characters, however, if I recall correctly, synonyms might not be available from MyAnimeList's search pages.

It might be available from the official MyAnimeList Beta API which came out earlier this year.