darfink / detour-rs

A cross-platform detour library written in Rust
Other
389 stars 71 forks source link

Update mmap-fixed's ``winapi`` dependency #32

Open Vurv78 opened 2 years ago

Vurv78 commented 2 years ago

I apologize in advance as this isn't an issue with this repository exactly, but you don't have a repo dedicated for this.

The dependency mmap-fixed is doubling my compile time simply because of the dependency on winapi 0.2 (which takes 4x as long to compile in comparison to 0.3), and is now causing warnings from cargo about code that will soon be rejected by Rust..

Would appreciate if the winapi dependency could be updated to 0.3+

khang06 commented 2 years ago

since this hasn't been updated for 20 days, i decided to just port it over to winapi 0.3 myself

[patch.crates-io]
mmap-fixed = { git = "https://github.com/khang06/rust-mmap-fixed-fixed.git", rev = "47116f5" }
ghost commented 2 years ago

@darfink :blush: Bump, it would be really nice if you can updates the dependencies:

[dependencies]

[dev-dependencies]

Moreover, I would recommand to switch to the new official windows crate.

Thanks.

xNxExOx commented 2 years ago

@darfink is this crate still maintained?

xNxExOx commented 2 years ago

@darfink you forget to push version 0.8.1 which is on https://crates.io/crates/detour to the github?

Rudxain commented 2 years ago

At this rate, I won't be surprised if we need mmap-fixed-fixed-repaired-updated-bumped-plus-ultra-max-super-pro

philpax commented 1 year ago

For those dropping by, I'm using @lostinspiration's fork with no issues: detour = {git = "https://github.com/lostinspiration/detour-rs.git"}