search

darglein / Snake-SLAM

MIT License
121 stars 23 forks source link

Is the snake-slam code content uploaded correctly? #3

Open coder12333444 opened 2 years ago

coder12333444 commented 2 years ago

@darglein Thank you very much for your work, I read the snake-slam paper and thought it was great, but when I compile the program, there are various errors, some internal errors, such as in SnakeGlobal.h: using Vec4f = Saiga::Vec4f;

using Vec3f = Saiga::Vec3f;

using Vec2f = Saiga::Vec2f; error: no type named 'Vec4f' in namespace 'Saiga' Next: inline Intrinsics4& K = mono_intrinsics.model.K; error: unknown type name 'Intrinsics4' Intrinsics4 is a file name, but it is used as a definition variable in the program, which is obviously wrong. I changed it to the following: inline IntrinsicsPinholed& K = mono_intrinsics.model.K; The program runs normally

In addition to these bugs, there are some bugs in FeatureDetector.h and FeatureDetector.cpp. So I would like to ask, is your program uploading the full version or the correct version? Had very high expectations for the snake-slam framework because of your paper and seeing your framework in a SenseTime competition, but the bugs did disappoint me a bit，so looking forward to your early reply！

coder12333444 commented 2 years ago

@darglein The latest progress, I have fixed all the above bugs, the reason is that your snake slam does not match the saiga master branch version, but when I compile, when the progress reaches 100%, libsnake.a will appear to Saiga::ORBExtractor: :Detect Undefined reference errors, I guess it should be that the snake module in the CMakeLists does not have a good link to the saiga module, so I hope you can take a look at these errors, after all, I have fixed a lot of bugs, and your slam framework is like this Excellent, makes people have to learn

darglein commented 2 years ago

Hello,

I finally had some time to update the Code base and fix some errors. Could you please try it again and check if it works now?

Best Darius