dargmuesli / nuxt-cookie-control

A highly configurable cookie banner for Nuxt.
MIT License
229 stars 43 forks source link

Update types.ts to allow more cookies group #217

Closed agracia-foticos closed 2 months ago

agracia-foticos commented 3 months ago

Update types to allow more cookies group

📚 Description

Fix https://github.com/dargmuesli/nuxt-cookie-control/issues/216

📝 Checklist

agracia-foticos commented 3 months ago

i generate new commits with full user customization cookies group, avoid types

agracia-foticos commented 2 months ago

I think those changes do not keep the current behavior as default. Also the project stops working with the current changeset: image Maybe try running the playground, the linter and the build to make sure the changes you propose are not breaking.

I feel the inconvenience, here you are a new version. i wait for your notices

dargmuesli commented 2 months ago

This changeset still breaks functionality, e.g. when trying to open the modal:

image

Also, it doesn't seem to have gotten the backwards compatibility added back in and the linter shows some errors:

image

I'll close this PR now, as I don't see enough progress towards non-breaking changes. Please only continue contributions that satisfy change requests or the build tooling.