darianhickman / VillageMakeover

Village Makeover is a nonprofit fundraising platform. As you build your online village, the money you spend builds real villages. For example buy a well for your village and you donate to construction of a real well in Ndola Zambia. At present all donations are managed through Seeds of Hope International Partners (www.sohip.org).
http://www.villagethegame.com
1 stars 1 forks source link

Coin dropping animation never stops #14

Closed darianhickman closed 9 years ago

darianhickman commented 9 years ago

Here's a sample of console about same time as error. Not sure if repeatable: game.js:1 IGE log [$i_114:ige] : Texture image (./assets/textures/sprites/wallSE.png) loaded successfully game.js:1 IGE log [$i_114:ige] : Texture image (./assets/textures/sprites/flowerPot1.png) loaded successfully game.js:1 IGE log [$i_114:ige] : Texture image (assets/textures/sprites/generator.png) loaded successfully game.js:1 Stack: at e.i as log ---- at e.$i_54.extend._applyCells (http://game.villagethegame.com/client/deploy/game.js:4:11585) ---- at e.$i_54.extend._textureLoaded (http://game.villagethegame.com/client/deploy/game.js:4:10960) ---- at HTMLImageElement.ige.isClient.ige._textureImageStore.(anonymous function).e.onload (http://game.villagethegame.com/client/deploy/game.js:4:1149) game.js:1 IGE warning [$i_55] : Cell width is a floating-point number! (Image Width 1055 / Number of Columns 3 = 351.6666666666667) in file: assets/textures/sprites/generator.png game.js:1 IGE log [$i_114:ige] : Texture image (./assets/textures/sprites/clothingLine.png) loaded successfully game.js:1 IGE log [$i_114:ige] : Texture image (./assets/textures/greendot.png) loaded successfully game.js:1 IGE log [$i_114:ige] : Texture image (./assets/textures/reddot.png) loaded successfully game.js:1 IGE log [$i_114:ige] : All textures have loaded game.js:1 IGE log [$i_14] : Setting up input event listeners... game.js:1 IGE log [$i_114:ige] : Starting engine... game.js:1 IGE log [$i_114:ige] : Engine started

umutnacak commented 9 years ago

I see the same bug now. I think game doesn't like zero coins. Did you change catalog making some items to have zero coin price?

darianhickman commented 9 years ago

Yep, i want the game design be either/or coins vs cash. Are you work on any fixes listed in Asana project? Put a heart on the one you're tackling.

Really glad to see these things moving forward.

On Wed, Mar 25, 2015 at 11:55 AM, umutnacak notifications@github.com wrote:

I see the same bug now. I think game doesn't like zero coins. Did you change catalog making some items to have zero coin price?

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/14#issuecomment-86093890 .

Darian Hickman | (310) 439-8573 | http://www.linkedin.com/in/darianhickman

umutnacak commented 9 years ago

Yes I am working on a couple of tasks now.

On Wed, Mar 25, 2015 at 6:13 PM, Darian Hickman notifications@github.com wrote:

Yep, i want the game design be either/or coins vs cash. Are you work on any fixes listed in Asana project? Put a heart on the one you're tackling.

Really glad to see these things moving forward.

On Wed, Mar 25, 2015 at 11:55 AM, umutnacak notifications@github.com wrote:

I see the same bug now. I think game doesn't like zero coins. Did you change catalog making some items to have zero coin price?

— Reply to this email directly or view it on GitHub < https://github.com/darian311/VillageMakeover/issues/14#issuecomment-86093890

.

Darian Hickman | (310) 439-8573 | http://www.linkedin.com/in/darianhickman

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/14#issuecomment-86100153 .

umutnacak commented 9 years ago

Can you check http://umutvillage.appspot.com/client/ I have updated a couple of things.

darianhickman commented 9 years ago

Looks good! I see you removed the energy, xp already. Looks like zoom in safari is working too.

darianhickman commented 9 years ago

So the coin animation no longer goes on forever. Now it just goes on too long. Can you trim it to 2 seconds?

umutnacak commented 9 years ago

I guess it calculates using number of coins. Do you want it to last always 2 seconds?

On Thu, Mar 26, 2015 at 1:39 AM, Darian Hickman notifications@github.com wrote:

So the coin animation no longer goes on forever. Now it just goes on too long. Can you trim it to 2 seconds?

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/14#issuecomment-86253781 .

darianhickman commented 9 years ago

Yeah two secs tops. if we changed coin tween based on quantity it would be at most 3 levels of coin tween.