search

darianhickman / VillageMakeover

Village Makeover is a nonprofit fundraising platform. As you build your online village, the money you spend builds real villages. For example buy a well for your village and you donate to construction of a real well in Ndola Zambia. At present all donations are managed through Seeds of Hope International Partners (www.sohip.org).
http://www.villagethegame.com
1 stars 1 forks source link

Need proper handling of 0 coins. #4

Closed darianhickman closed 9 years ago

darianhickman commented 9 years ago

Javascript errors occur when trying to build an object without the required resources. For example, trying to build Hut 1 without any money, or Hut 2 with less than 10 coins. When this is attempted, nothing happens and the game freezes for a little bit. No in game error given. Javascript errors shown below. https://mail.google.com/mail/u/0/?ui=2&ik=dcc9604119&view=fimg&th=14c0ac8da6c5c2b2&attid=0.2&disp=emb&realattid=ii_14c0ab7ae4aa7174&attbid=ANGjdJ-AXtM-WREzCqx-eO_q022WTH7slJzh_em3lI1x2SoY9pyRstmBogkwovKhY-B5Kf6wqNCiebWkYjly_jpblu0EBTzojfk8yCnbRqknXGk0nyDcZSMr0-rwz0o&sz=s0-l75-ft&ats=1426524247094&rm=14c0ac8da6c5c2b2&zw&atsh=1

umutnacak commented 9 years ago

There is a pull request targeting this issue.

darianhickman commented 9 years ago

I saw the error is eliminated. Yay! How are things going with integrating the new Coins dialog I sent. Hopefully the logic is parallel and simpler than the Cash Dialog.

umutnacak commented 9 years ago

Well, now I am making the Coins dialog, and I need to ask you something. If the player doesn't have enough village bucks then what happens? I decided to show cash dialog, but maybe you want something different. I will make some commits after dinner. You can revise the code and make suggestions.

On Thu, Mar 19, 2015 at 5:48 PM, Darian Hickman notifications@github.com wrote:

I saw the error is eliminated. Yay! How are things going with integrating the new Coins dialog I sent. Hopefully the logic is parallel and simpler than the Cash Dialog.

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/4#issuecomment-83640475 .

darianhickman commented 9 years ago

Perfect! That's exactly what should happen. I'll double check FarmVille to see what kind of messages it needs though On Thu, Mar 19, 2015 at 12:54 PM umutnacak notifications@github.com wrote:

Well, now I am making the Coins dialog, and I need to ask you something. If the player doesn't have enough village bucks then what happens? I decided to show cash dialog, but maybe you want something different. I will make some commits after dinner. You can revise the code and make suggestions.

On Thu, Mar 19, 2015 at 5:48 PM, Darian Hickman notifications@github.com wrote:

I saw the error is eliminated. Yay! How are things going with integrating the new Coins dialog I sent. Hopefully the logic is parallel and simpler than the Cash Dialog.

— Reply to this email directly or view it on GitHub < https://github.com/darian311/VillageMakeover/issues/4#issuecomment-83640475

.

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/4#issuecomment-83660491 .

umutnacak commented 9 years ago

Please review the code in pull request. I am going to make a deploy to umutvillage in a couple of minutes.

On Thu, Mar 19, 2015 at 7:56 PM, Darian Hickman notifications@github.com wrote:

Perfect! That's exactly what should happen. I'll double check FarmVille to see what kind of messages it needs though

On Thu, Mar 19, 2015 at 12:54 PM umutnacak notifications@github.com wrote:

Well, now I am making the Coins dialog, and I need to ask you something. If the player doesn't have enough village bucks then what happens? I decided to show cash dialog, but maybe you want something different. I will make some commits after dinner. You can revise the code and make suggestions.

On Thu, Mar 19, 2015 at 5:48 PM, Darian Hickman < notifications@github.com> wrote:

I saw the error is eliminated. Yay! How are things going with integrating the new Coins dialog I sent. Hopefully the logic is parallel and simpler than the Cash Dialog.

— Reply to this email directly or view it on GitHub <

https://github.com/darian311/VillageMakeover/issues/4#issuecomment-83640475

.

— Reply to this email directly or view it on GitHub < https://github.com/darian311/VillageMakeover/issues/4#issuecomment-83660491

.

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/4#issuecomment-83693983 .

darianhickman commented 9 years ago

Can you change assets to coins? Looks good!

darianhickman commented 9 years ago

Let's change starting coins to 1000 at least or higher if it's lower than that now.

umutnacak commented 9 years ago

Ok

On Wed, Mar 25, 2015 at 7:26 PM, Darian Hickman notifications@github.com wrote:

Let's change starting coins to 1000 at least or higher if it's lower than that now.

— Reply to this email directly or view it on GitHub https://github.com/darian311/VillageMakeover/issues/4#issuecomment-86131637 .

umutnacak commented 9 years ago

I'm closing a couple of issues. You can reopen them if you are not satisfied.